fix(openai): relax tool call validation for Ollama compatibility#113
Open
Gustave-241021 wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix(openai): relax tool call validation for Ollama compatibility#113Gustave-241021 wants to merge 1 commit intocharmbracelet:mainfrom
Gustave-241021 wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.related link:
issue: charmbracelet/crush#1767
crush's fix: charmbracelet/crush#1774
Problem Attribution:
Ollama's OpenAI-compatible streaming API does not include id and type fields in tool call delta chunks, unlike the standard OpenAI format. This causes the fantasy library's strict validation to fail, resulting in Crush getting stuck in a "waiting" state.
Fix: Relaxed tool call validation in language_model.go to handle missing fields gracefully:
Risk Mitigation: